[ previous ] [ next ] [ threads ]
 To :  YATE <yate@v...>
 From :  Marian <marian@v...>
 Subject :  Re: [yate] MWI PATCH Contact in 200 OK response to SUBSCRIBE
 Date :  Fri, 05 Sep 2008 14:45:58 +0300
Hi,

The change was commited. See svn.

Marian

Dave Giffin wrote:
> Index: sipfeatures.cpp
> ===================================================================
> --- sipfeatures.cpp    (revision 2182)
> +++ sipfeatures.cpp    (working copy)
> @@ -223,6 +223,7 @@
>     return false;
> 
>     msg.setParam("osip_Expires",sExpires);
> +    msg.setParam("osip_Contact",msg.getValue("sip_contact"));
>     msg.setParam("code","200");
>     return true;
> }
> 
> Dave Giffin wrote:
>> Hi,
>> Yes those changes work correctly, thanks.
>>
>> Although the OK to the SUBSCRIBE still does not contain a Contact, 
>> which just happens to fail the X-Lite Softphone - possibly others.
>>
>> This can be fixed by either appending osip_Contact to the msg in 
>> YSipSubscribeHandler::received(Message &msg)
>> or allowing message.cpp SIPMessage::complete to deal with SUBSCRIBE:
>> note the following code in SIPMessage::complete only adds contact for 
>> responses to an INVITE
>>    if ((method == "INVITE") && !getHeader("Contact")) {
>>    // automatically add a contact field to (re)INVITE and its answers
>>
>> both fixes are easy.
>>
>>
>> Anand Kumria wrote:
>>> On Tue, 02 Sep 2008 19:34:49 +0300, Paul Chitescu wrote:
>>>
>>>  
>>>> Hi!
>>>>
>>>> The Messages-Waiting fix is in SVN.
>>>>
>>>> Adding the port in Contact: is insufficient, it may work with some user
>>>> agents but not with all. Not just the port but also any URI parameters
>>>> (usually ;line=randomstring) must be preserved and added to the URI in
>>>> the NOTIFY message.
>>>>
>>>> We are testing a different change. When it passes the tests it will be
>>>> commited to SVN.
>>>>     
>>>
>>> Dave have you had a chance to check recent SVN to confirm if it 
>>> Pauls' changes address the MWI problem?
>>>
>>> Cheers,
>>> Anand
>>>
>>>   
>>
>