[ previous ] [ next ] [ threads ]
 To :  yate@v...
 From :  Allan Sandfeld Jensen <linux@c...>
 Subject :  Re: [yate] Patch storm
 Date :  Wed, 16 Jun 2010 21:10:56 +0200
Hi Paul

On Wednesday 16 June 2010, Paul Chitescu wrote:
> More commits from Allan's patches:
> 
> - Rev. 3379 and Rev. 3380 hold the changes in
> 0003-Minor-engine-improvements with some extra checks. Adding the nodename
> is a great idea, it simplifies writing cleanup queries in a cluster.
> 
Exactly, I forget to write what we use it for, but you guessed it. To cleanup 
after a node crashes in cluster, you can add startup queries in register.conf 
but they need the nodename.

> - Rev. 3382 implements the idea in 0016-Regexroute-generic-message-handler
> but by extending the current [extra] section syntax instead of replacing
> it. Additionally it is possible to specify which parameter to match by
> default and the code checks if the target section (context) exists.
> 
Looks goods. But it took me some time to understand how it was even possible 
to skip the match argument. I guess the syntax would be 
"message.type=prio,,context"? 
Not that it is terribly important.

> - Rev. 3385 is basically 0011-Early-cancel-flag with some minor changes.
> This patch seems to help a lot in avoiding crashes at shutdown.
> 
Not much of my patch anymore, this is practically a full rewrite :) But very 
good.

> - Rev. 3387 is 0017-Regexroute-default-value with simplified code (not
> shorter but easier to follow) and extra info in debugging.
> 
Thanks. Keep up the good work.

Regards
Allan